Add missing ListItemComponent prop to VirtualizedList/FlatList/SectionList TypeScript types - #57754
Closed
aravi365 wants to merge 1 commit into
Closed
Add missing ListItemComponent prop to VirtualizedList/FlatList/SectionList TypeScript types#57754aravi365 wants to merge 1 commit into
ListItemComponent prop to VirtualizedList/FlatList/SectionList TypeScript types#57754aravi365 wants to merge 1 commit into
Conversation
ListItemComponent is a documented, public prop of VirtualizedList (and thus FlatList and SectionList) in the Flow source, but was missing from the hand-written TypeScript definitions, causing a type error when used.
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
|
@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this in D114061127. |
|
@fabriziocucci merged this pull request in 5306e92. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListItemComponentis a valid prop onFlatList,SectionListandVirtualizedList(it's in the Flow types inVirtualizedListProps.js), but it's missing from the.d.ts, so TypeScript errors on it even though it works at runtime.Added it to
VirtualizedListWithoutRenderItemPropsnext to the otherList*Componentprops, so all three inherit it.Changelog:
[GENERAL] [ADDED] - Add missing ListItemComponent type to VirtualizedList props
Test Plan
Errors on
main, type-checks with the change:Type-only, addition only, no runtime changes.